-
-
Notifications
You must be signed in to change notification settings - Fork 206
refactor: Update dart dependencys #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update dart dependencys #967
Conversation
refactor: Add `CONTRIBUTING.md`
Thanks for opening this pull request! |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #967 +/- ##
==========================================
- Coverage 39.63% 39.60% -0.04%
==========================================
Files 60 60
Lines 3333 3333
==========================================
- Hits 1321 1320 -1
- Misses 2012 2013 +1 ☔ View full report in Codecov by Sentry. |
Considering this ci error, I think it is better to stop supporting Dart below 3 Also, many of the new features are unusable and developers encounter conflicts and issues! |
According to our support policy, dart 2.x will be supported until March 2024. What is the issue? |
We are unable to update the Because parse_server_sdk depends on http >=1.0.0 which requires SDK version >=3.0.0 <4.0.0, version solving failed. |
I believe this is a special case because it's the first stable release 1.0.0, so the developers just decided to cut Dart 2.x support, which is fair enough. The issue is more on our side that we decided to use an unstable library (version 0.x). This library could have introduced breaking changes with any release, so we took some risk there. We should have looked for an alternative instead. That's a lesson for us when considering dependencies. Under normal circumstances I don't think we've seen such a drastic drop for support, Dart 3 has been released just 4 months ago. Such a short forced upgrade cycle is unusual (they are more like years in most ecosystems) and would likely be challenging for developers, so I think our policy for 1 year support is still good. I think our options are:
|
I think option b is better. There's a method called Regarding the |
Can we remove it then? |
No, the |
Apologies, I've misread your comment. |
I'm sorry for my language. English is not my native language, but I am improving it. Please let me know if there is anything wrong. ❤️ Regarding this PR, I think it is better to wait for the result of Dart support policy. |
I think there is no need for this PR anymore |
Pull Request
Issue
Update dart dependencys
Closes: #966
Approach
n/a
Tasks