Skip to content

Fix User Linking tests #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fix User Linking tests #1209

merged 1 commit into from
Aug 17, 2020

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 17, 2020

I accidentally deleted the developer account used for testing. Changed the access keys to fix Twitter failing tests.

@dplewis dplewis requested review from davimacedo and mtrezza August 17, 2020 16:36
@mtrezza
Copy link
Member

mtrezza commented Aug 17, 2020

I assumed a temporary issue on FB side, glad this spotted this.

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #1209 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1209   +/-   ##
=======================================
  Coverage   92.34%   92.34%           
=======================================
  Files          54       54           
  Lines        5294     5294           
  Branches     1191     1191           
=======================================
  Hits         4889     4889           
  Misses        405      405           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad00118...2ff44a9. Read the comment docs.

@dplewis dplewis merged commit af85014 into master Aug 17, 2020
@dplewis dplewis deleted the fix-twitter-auth branch August 17, 2020 16:45
@mtrezza
Copy link
Member

mtrezza commented Aug 19, 2020

@dplewis I assume we need to create a release for this SDK and point Parse Server to it, to fix the issue of failing tests for Parse Server PRs? E.g. parse-community/parse-server#6861

@dplewis
Copy link
Member Author

dplewis commented Aug 19, 2020

I’ll have a look today. I think it might be a separate issue.

@mtrezza
Copy link
Member

mtrezza commented Aug 19, 2020

Ah, right, the Parse Server issue is related to the Facebook domain certificate, sorry for the mix-up. I've opened an issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants