Update tests #1278
Merged
Update tests #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump parse-server to [#43d9af8 ](parse-community/parse-server@43d9af8)
Codecov Report
@@ Coverage Diff @@
## master #1278 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 5434 5434
Branches 1219 1219
=========================================
Hits 5434 5434 Continue to review full report at Codecov.
|
davimacedo
reviewed
Dec 11, 2020
|
Nevermind. I've just seen the other related PRs. |
davimacedo
approved these changes
Dec 11, 2020
|
LGTM, although I am starting to wonder whether we have the best approach when it comes to reserved field names. Why would a developer have to care about internally used field names. Maybe we should just encode the field names in a different way, so that they are separate from any JS property names. But that's a whole other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump parse-server to #43d9af8