-
-
Notifications
You must be signed in to change notification settings - Fork 596
ci: Add support for Parse Server 6 #1641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps [parse-server](https://github.com/parse-community/parse-server) from `7cb266b` to `d19acf1`. - [Release notes](https://github.com/parse-community/parse-server/releases) - [Commits](parse-community/parse-server@7cb266b...d19acf1) --- updated-dependencies: - dependency-name: parse-server dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Thanks for opening this pull request!
|
@mtrezza The SDK should still be compatible with previous versions, it's only the startup method which is a |
Codecov ReportBase: 99.89% // Head: 99.89% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## alpha #1641 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 61 61
Lines 5973 5973
Branches 1367 1367
=======================================
Hits 5967 5967
Misses 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@mtrezza Is this ready to merge? I have to copy the startup code to make PR's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@dblythy is this ready for merge?
Is this a breaking change? If so, we'd need to compose a note for the changelog.
If this breaks compatibility with Parse Server <6, a compatibility table needs to be added to the README for Parse Server.
@mtrezza Looks like its linted code and the server is only here for testing. No breaking changes. |
There is also a change in package lock, that's strange if there are only test and lint changes. |
@mtrezza You can't test against latest of Parse Server without bumping it. In the package-lock.json they are all dev dependencies. |
Ah right, we import the alpha branch of Parse Server here, hence the lock file changes. Really not an ideal solution. Let's think this through once more. So this is actually not a It may be problematic that we are only testing with the latest Parse Server alpha branch. If we could add a CI test for at least the latest Parse Server 5 (branch |
To get ahead here, let's merge this for now and assume the SDK stays compatible with Parse Server 5. We should add Parse Server 5 testing to the CI to verify compatibility, therefore opened #1651. |
🎉 This change has been released in version 4.0.0-beta.1 |
🎉 This change has been released in version 4.0.0 |
🎉 This change has been released in version 4.0.0-alpha.6 |
New Pull Request Checklist
Issue Description
SDK does not currently support Parse Server 6, as the startup method has changed.
Closes: #1637
Approach
TODOs before merging