Skip to content

ci: Add support for Parse Server 6 #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Dec 23, 2022

New Pull Request Checklist

Issue Description

SDK does not currently support Parse Server 6, as the startup method has changed.

Closes: #1637

Approach

TODOs before merging

  • Add tests

dependabot bot and others added 2 commits December 22, 2022 14:01
Bumps [parse-server](https://github.com/parse-community/parse-server) from `7cb266b` to `d19acf1`.
- [Release notes](https://github.com/parse-community/parse-server/releases)
- [Commits](parse-community/parse-server@7cb266b...d19acf1)

---
updated-dependencies:
- dependency-name: parse-server
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 23, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy
Copy link
Member Author

dblythy commented Dec 23, 2022

@mtrezza The SDK should still be compatible with previous versions, it's only the startup method which is a devDependancy that breaks the CI

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (88f9e39) compared to base (dfb5196).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 88f9e39 differs from pull request most recent head c4f1472. Consider uploading reports for the commit c4f1472 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1641   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5973     5973           
  Branches     1367     1367           
=======================================
  Hits         5967     5967           
  Misses          6        6           
Impacted Files Coverage Δ
src/StorageController.react-native.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy changed the title Support PS6 feat: Support PS6 Dec 28, 2022
@dblythy dblythy requested a review from a team December 28, 2022 04:16
@dplewis
Copy link
Member

dplewis commented Jan 6, 2023

@mtrezza Is this ready to merge? I have to copy the startup code to make PR's

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
@dblythy is this ready for merge?

Is this a breaking change? If so, we'd need to compose a note for the changelog.

If this breaks compatibility with Parse Server <6, a compatibility table needs to be added to the README for Parse Server.

@mtrezza mtrezza changed the title feat: Support PS6 feat: Support for Parse Server 6 Jan 6, 2023
@dplewis
Copy link
Member

dplewis commented Jan 6, 2023

@mtrezza Looks like its linted code and the server is only here for testing. No breaking changes.

@mtrezza
Copy link
Member

mtrezza commented Jan 6, 2023

There is also a change in package lock, that's strange if there are only test and lint changes.

@dplewis
Copy link
Member

dplewis commented Jan 6, 2023

@mtrezza You can't test against latest of Parse Server without bumping it. In the package-lock.json they are all dev dependencies. dev: true. Dev deps don't affect the build

@mtrezza
Copy link
Member

mtrezza commented Jan 6, 2023

Ah right, we import the alpha branch of Parse Server here, hence the lock file changes. Really not an ideal solution.

Let's think this through once more. So this is actually not a feat commit, but a ci commit, since it's only adapting the tests. If we are adapting the tests for Parse Server 6, we are not testing anymore against Parse Server 5. Since Parse Server 6 has breaking changes, I assume there is a also a chance that the Parse JS SDK becomes incompatible with Parse Server 5 at some point.

It may be problematic that we are only testing with the latest Parse Server alpha branch. If we could add a CI test for at least the latest Parse Server 5 (branch release-5.x.x), we would know when the compatibility breaks.

@mtrezza
Copy link
Member

mtrezza commented Jan 8, 2023

To get ahead here, let's merge this for now and assume the SDK stays compatible with Parse Server 5. We should add Parse Server 5 testing to the CI to verify compatibility, therefore opened #1651.

@dblythy dblythy changed the title feat: Support for Parse Server 6 ci: Support for Parse Server 6 Jan 8, 2023
@mtrezza mtrezza changed the title ci: Support for Parse Server 6 ci: Add support for Parse Server 6 Jan 9, 2023
@mtrezza mtrezza merged commit 7e1ed12 into parse-community:alpha Jan 9, 2023
mtrezza pushed a commit to mtrezza/Parse-SDK-JS that referenced this pull request Jan 22, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 23, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 23, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.6

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 27, 2023
@mtrezza mtrezza mentioned this pull request Mar 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for Parse Server 6
4 participants