Skip to content

test: Change tests to use native MongoDB aggregation pipeline syntax #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 16, 2023
Merged

test: Change tests to use native MongoDB aggregation pipeline syntax #1654

merged 6 commits into from
Jan 16, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 15, 2023

New Pull Request Checklist

Issue Description

CI is failing on latest Parse Server as the aggregate syntax has changed

Closes: #1637

Approach

Changes syntax

TODOs before merging

  • Add tests

dependabot bot and others added 3 commits January 10, 2023 14:01
@dependabot
refactor: bump parse-server from d19acf1 to 62b3426
e84b23e 
Bumps [parse-server](https://github.com/parse-community/parse-server) from `d19acf1` to `62b3426`.
- [Release notes](https://github.com/parse-community/parse-server/releases)
- [Commits](parse-community/parse-server@d19acf1...62b3426)

---
updated-dependencies:
- dependency-name: parse-server
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dblythy
ci: support new aggregate syntax
e92512c
@dblythy
Merge branch 'dependabot/npm_and_yarn/parse-server-62b3426' into aggr…
0441574 
…egate-syntax
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 15, 2023 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy dblythy closed this Jan 15, 2023
@dblythy dblythy reopened this Jan 15, 2023
@dblythy
Copy link
Member Author

dblythy commented Jan 15, 2023

Not sure when npm ci is failing on node 14 - @mtrezza do you have any ideas

@codecov
Copy link

codecov bot commented Jan 15, 2023 •
edited
Loading

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (2cc48bf) compared to base (7e1ed12).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##            alpha    #1654   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5973     5973           
  Branches     1367     1367           
=======================================
  Hits         5967     5967           
  Misses          6        6
Impacted Files Coverage Δ
src/ParseQuery.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Jan 15, 2023 •
edited
Loading

Maybe this is because of parse-community/parse-server#8381 and we may have to add the same git protocol fix to the CI workflow here?

@dblythy
Copy link
Member Author

dblythy commented Jan 15, 2023

Tests a bit flaky

@dblythy dblythy closed this Jan 15, 2023
@dblythy dblythy reopened this Jan 15, 2023
@mtrezza
Copy link
Member

mtrezza commented Jan 15, 2023

The issue seems to be solved with the recent commit; rerunning the CI.

@mtrezza mtrezza changed the title ci: Support new aggregate syntax test: Change tests to use new MongoDB aggregation pipeline syntax Jan 15, 2023
@mtrezza mtrezza changed the title test: Change tests to use new MongoDB aggregation pipeline syntax test: Change tests to use native MongoDB aggregation pipeline syntax Jan 15, 2023
@mtrezza mtrezza merged commit 6870a13 into parse-community:alpha Jan 16, 2023
mtrezza pushed a commit to mtrezza/Parse-SDK-JS that referenced this pull request Jan 22, 2023
@dblythy @mtrezza
test: Change tests to use native MongoDB aggregation pipeline syntax (p…
cb1aa0f 
…arse-community#1654)
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 23, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 23, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.6

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare for Parse Server 6
3 participants
@dblythy @mtrezza @parseplatformorg