feat: Upgrade Node Package Manager lock file `package-lock.json` to version 2 #1729

dplewis · 2023-02-04T02:45:14Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

I want to see what the effects are against the CI.

Closes: #1728

Approach

Update package-lockfile to V2
Update lockfile checker in CI
Improve CI caching to individual cache per node version
Move mongodb runner from CI to Dev Dependencies
Update semantic-release packages

…sion 2

parse-github-assistant · 2023-02-04T02:45:17Z

Thanks for opening this pull request!

❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

codecov · 2023-02-04T02:50:50Z

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (3c18815) compared to base (16535a4).
Patch has no changes to coverable lines.

❗ Current head 3c18815 differs from pull request most recent head e35cd62. Consider uploading reports for the commit e35cd62 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##            alpha    #1729   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          61       61           
  Lines        5992     5992           
  Branches     1374     1374           
=======================================
  Hits         5986     5986           
  Misses          6        6

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

dplewis · 2023-02-04T03:14:14Z

@mtrezza Looks like mongodb-runner and node 14 are working well here.

mtrezza · 2023-02-04T11:34:19Z

Looks like mongodb-runner and node 14 are working well here.

Great to hear, that's why we didn't see the issue in the Parse Server CI. So we can keep mongodb-runner. Btw, they made a recent release 3 days ago (albeit just a tag), so there is some maintenance going on it seems. What's left is to move it to the dev dependencies, but we'll do that in a separate PR related to #1730 since we want it to have a distinct changelog entry.

package.json

This reverts commit fbcfb7b.

package.json

mtrezza

Looks good! Get's get this merged if the CI passes...

mtrezza · 2023-02-04T21:57:34Z

Uh, there is a conflict after merging alpha, could you take a look?

mtrezza

Looks good!

mtrezza · 2023-02-04T22:27:08Z

This PR seems to be done, can we merge? Any other issues please in separate PRs.

dplewis · 2023-02-04T22:28:06Z

Its good to merge

mtrezza · 2023-02-04T22:28:58Z

Glad to see this Node 14 issue finally fixed

# [4.0.0-alpha.10](4.0.0-alpha.9...4.0.0-alpha.10) (2023-02-04) ### Features * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))

parseplatformorg · 2023-02-04T22:31:06Z

🎉 This change has been released in version 4.0.0-alpha.10

# [4.1.0-beta.1](4.0.1...4.1.0-beta.1) (2023-03-01) ### Bug Fixes * `LiveQuerySubscription.unsubscribe` resolves promise before unsubscribing completes ([#1727](#1727)) ([1c96205](1c96205)) * Node engine version upper range is <19 despite Node 19 support ([#1732](#1732)) ([febe187](febe187)) * Saving a new `Parse.Object` with an unsaved `Parse.File` fails ([#1662](#1662)) ([16535a4](16535a4)) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660)) * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))

parseplatformorg · 2023-03-01T15:22:59Z

🎉 This change has been released in version 4.1.0-beta.1

# [4.1.0-alpha.1](4.0.1...4.1.0-alpha.1) (2023-03-01) ### Bug Fixes * `LiveQuerySubscription.unsubscribe` resolves promise before unsubscribing completes ([#1727](#1727)) ([1c96205](1c96205)) * Node engine version upper range is <19 despite Node 19 support ([#1732](#1732)) ([febe187](febe187)) * Saving a new `Parse.Object` with an unsaved `Parse.File` fails ([#1662](#1662)) ([16535a4](16535a4)) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660)) * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))

parseplatformorg · 2023-03-01T15:50:21Z

🎉 This change has been released in version 4.1.0-alpha.1

# [4.1.0](4.0.1...4.1.0) (2023-05-01) ### Bug Fixes * `LiveQuerySubscription.unsubscribe` resolves promise before unsubscribing completes ([#1727](#1727)) ([1c96205](1c96205)) * Node engine version upper range is <19 despite Node 19 support ([#1732](#1732)) ([febe187](febe187)) * Saving a new `Parse.Object` with an unsaved `Parse.File` fails ([#1662](#1662)) ([16535a4](16535a4)) ### Features * `LiveQueryClient.close` returns promise when WebSocket closes ([#1735](#1735)) ([979d660](979d660)) * Upgrade Node Package Manager lock file `package-lock.json` to version 2 ([#1729](#1729)) ([e993786](e993786))

parseplatformorg · 2023-05-01T22:13:42Z

🎉 This change has been released in version 4.1.0

feat: Upgrade Node Package Manager lock file package-lock.json to ver…

334f0c2

…sion 2

bump semantic-release

c007c85

dplewis requested a review from a team February 4, 2023 03:54

bump core-js

9af0ec1

mtrezza requested changes Feb 4, 2023

View reviewed changes

package.json Show resolved Hide resolved

improve CI

a3a5370

mtrezza changed the title ~~feat: Upgrade Node Package Manager lock file package-lock.json to ver…~~ feat: Upgrade Node Package Manager lock file package-lock.json to version 2 Feb 4, 2023

dplewis added 2 commits February 4, 2023 15:32

downgrade semantic-release

fbcfb7b

Revert "downgrade semantic-release"

a154ced

This reverts commit fbcfb7b.

mtrezza reviewed Feb 4, 2023

View reviewed changes

package.json Show resolved Hide resolved

dplewis and others added 2 commits February 4, 2023 15:51

revert node engine

611a46b

Merge branch 'alpha' into package-lock-json-v2

ae95dbe

mtrezza approved these changes Feb 4, 2023

View reviewed changes

fix conflict

e73d2ba

dplewis closed this Feb 4, 2023

dplewis reopened this Feb 4, 2023

dplewis added 2 commits February 4, 2023 16:10

Merge branch 'master' into package-lock-json-v2

61957b9

Update package-lock.json

3c18815

mtrezza approved these changes Feb 4, 2023

View reviewed changes

fix flaky test

e35cd62

mtrezza merged commit e993786 into parse-community:alpha Feb 4, 2023

dplewis deleted the package-lock-json-v2 branch February 4, 2023 22:28

parseplatformorg added the state:released-alpha Released as alpha version label Feb 4, 2023

dplewis mentioned this pull request Feb 5, 2023

Node 14 CI takes long to finish #1730

Closed

4 tasks

parseplatformorg added the state:released-beta Released as beta version label Mar 1, 2023

parseplatformorg added the state:released Released as stable version label May 1, 2023

Uh oh!

feat: Upgrade Node Package Manager lock file package-lock.json to version 2 #1729

feat: Upgrade Node Package Manager lock file package-lock.json to version 2 #1729

Uh oh!

Conversation

dplewis commented Feb 4, 2023 • edited by mtrezza Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request

Issue

Approach

Uh oh!

parse-github-assistant bot commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thanks for opening this pull request!

Uh oh!

codecov bot commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dplewis commented Feb 4, 2023

Uh oh!

mtrezza commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

mtrezza commented Feb 4, 2023

Uh oh!

mtrezza left a comment

Choose a reason for hiding this comment

Uh oh!

mtrezza commented Feb 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dplewis commented Feb 4, 2023

Uh oh!

mtrezza commented Feb 4, 2023

Uh oh!

parseplatformorg commented Feb 4, 2023

Uh oh!

parseplatformorg commented Mar 1, 2023

Uh oh!

parseplatformorg commented Mar 1, 2023

Uh oh!

parseplatformorg commented May 1, 2023

Uh oh!

Uh oh!

feat: Upgrade Node Package Manager lock file `package-lock.json` to version 2 #1729

feat: Upgrade Node Package Manager lock file `package-lock.json` to version 2 #1729

dplewis commented Feb 4, 2023 •

edited by mtrezza

Loading

parse-github-assistant bot commented Feb 4, 2023 •

edited

Loading

codecov bot commented Feb 4, 2023 •

edited

Loading

mtrezza commented Feb 4, 2023 •

edited

Loading

mtrezza commented Feb 4, 2023 •

edited

Loading