Skip to content

fix: Remove unused option sessionToken from Parse.Query.aggregate #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Apr 1, 2025

Pull Request

Issue

Aggregate queries don't use sessionTokens and most likely never will.

Closes: #1393

Approach

Remove options from distinct and aggregate queries

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

parse-github-assistant bot commented Apr 1, 2025

🚀 Thanks for opening this pull request!

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (451ad04) to head (ec326d0).
Report is 2 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2547   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6244      6238    -6     
  Branches      1468      1448   -20     
=========================================
- Hits          6244      6238    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis dplewis requested a review from a team April 1, 2025 20:31
@mtrezza mtrezza changed the title fix: Remove unused sessionToken option for aggregate queries fix: Remove unused option sessionToken from Parse.Query.aggregate Apr 2, 2025
@mtrezza mtrezza merged commit c7015ba into parse-community:alpha Apr 2, 2025
9 of 10 checks passed
parseplatformorg pushed a commit that referenced this pull request Apr 2, 2025
# [6.1.0-alpha.5](6.1.0-alpha.4...6.1.0-alpha.5) (2025-04-02)

### Bug Fixes

* Remove unused option `sessionToken` from `Parse.Query.aggregate` ([#2547](#2547)) ([c7015ba](c7015ba))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.5

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 2, 2025
parseplatformorg pushed a commit that referenced this pull request Apr 4, 2025
## [6.1.1](6.1.0...6.1.1) (2025-04-04)

### Bug Fixes

* Remove unused option `sessionToken` from `Parse.Query.aggregate` ([#2547](#2547)) ([c7015ba](c7015ba))
* Security upgrade tar-fs from 2.1.1 to 2.1.2 ([#2540](#2540)) ([44eeacd](44eeacd))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-alpha Released as alpha version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregate query does not honor sessionToken option if passed
3 participants