Add unit test towards #494 #497
Conversation
nrchandan
force-pushed
the
saveAll-fail
branch
from
37dc09c to
1ab8513
Compare
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 84.03% 84.03%
=======================================
Files 47 47
Lines 3801 3801
Branches 869 869
=======================================
Hits 3194 3194
Misses 607 607Continue to review full report at Codecov.
|
| it('cannot set an invalid date', (done) => { | ||
| let obj = new TestObject(); | ||
| obj.set('when', new Date(Date.parse(null))); | ||
| Parse.Object.saveAll([obj]).fail((e) => { |
There was a problem hiding this comment.
This actually succeeds , but failed the CI as the done() is never called.
There was a problem hiding this comment.
I just pushed this along with the other PR. This test passes after PR #495. So, we know that the unit test covers this fail condition. However, coverage is still down. What should I do?
There was a problem hiding this comment.
I should also mention that I copy pasted this test case from just above this unit test. That one invokes save instead of saveAll, and passes. It is the saveAll that was misbehaving.
|
You should probably put the test and the fix in the same PR. Also your test is broken, as you should have a |
|
The test uses the same convention followed in the tests surrounding it. I
have merged this test with the original PR. I just wanted to see if the
test fails without my fix, and it doesn't. So, my fix works. Could you
please take a look at #495. I will close this one out.
…On Oct 24, 2017 6:31 AM, "Florent Vilmart" ***@***.***> wrote:
You should probably put the test and the fix in the same PR. Also your
test is broken, as you should have a done.fail in the ‘success’ handler
if that’s your intention to test.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#497 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABYXzoFbzxbm5GnCxJLwxbx8EP7odrmPks5svTbygaJpZM4QDNHo>
.
|
|
I just wanted to see if the test fails without my fix, and it does. |
|
Closing this one as it is incorporated in #495 |
This shouldn't fail ideally.