Skip to content

Fix for the formatting of the ParseFile comment that has #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

acinader
Copy link
Contributor

Currently, for me, the ParseFile Constructor API docs has a

 tag that is not rendering:
screen shot 2018-07-11 at 4 17 20 pm

this fix, while not ideal, is a good improvement.
screen shot 2018-07-11 at 4 14 00 pm

I'm game to try someother approaches?

@acinader acinader force-pushed the doc-fix-parse-file branch from 85c5ce1 to 42bd840 Compare July 11, 2018 20:45
@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #600 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          48       48           
  Lines        4039     4039           
  Branches      911      911           
=======================================
  Hits         3416     3416           
  Misses        623      623
Impacted Files Coverage Δ
src/ParseFile.js 80% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2640391...42bd840. Read the comment docs.

@flovilmart
Copy link
Contributor

@acinader that looks great! Thanks!

@flovilmart flovilmart merged commit e60d4c5 into parse-community:master Jul 26, 2018
@acinader acinader deleted the doc-fix-parse-file branch July 26, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants