-
-
Notifications
You must be signed in to change notification settings - Fork 597
⚡ Release v2.0.1 #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡ Release v2.0.1 #624
Conversation
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=======================================
Coverage 84.98% 84.98%
=======================================
Files 48 48
Lines 3850 3850
Branches 871 871
=======================================
Hits 3272 3272
Misses 578 578 Continue to review full report at Codecov.
|
13a2500
to
93439c1
Compare
93439c1
to
a17fa61
Compare
@miconblog can you have a look there? as you went through the upgrade process, I'd like to release the fixes in the 2.0.1 as well as the upgrading guide. |
yeb! i am already reading this guide. and migrating my project |
Let me know if there's anything missing or that you believe we should put :) |
src/CloudCode.js
Outdated
@@ -16,19 +18,19 @@ | |||
* | |||
* If you want to use afterDelete for a predefined class in the Parse JavaScript SDK (e.g. {@link Parse.User}), you should pass the class itself and not the String for arg1. | |||
* ``` | |||
* Parse.Cloud.afterDelete('MyCustomClass', (request) => { | |||
* Parse.Cloud.afterDelete('MyCustomClass', async (request) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just curios about this CloudCode. Is it work in browser now? or is your long-team plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's in the server, but that's easier to have the whole cloud code API documentation with the rest of the JS SDK, we may move it at a later point if we generate a bigger API docs for parse-server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, i see i just confused :)
src/CloudCode.js
Outdated
@@ -62,19 +64,19 @@ | |||
* | |||
* If you want to use beforeDelete for a predefined class in the Parse JavaScript SDK (e.g. {@link Parse.User}), you should pass the class itself and not the String for arg1. | |||
* ``` | |||
* Parse.Cloud.beforeDelete('MyCustomClass', (request, response) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it remove response in beforeDelete?
i was used it before like this:
Parse.Cloud.beforeDelete('RedBookNote', async function (request, response) {
response.success();
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In parse-server 3.0 (the the docs update is for parse-server 3.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this leads to a lot of confusion, I'll bring in the CLoud Code docs in parse-server instead. And just add the link here. I'll revert cloud code docs for now :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goood :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job! thanks :)
This PR does a few things: