Skip to content

⚡ Release v2.0.1 #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 9, 2018
Merged

⚡ Release v2.0.1 #624

merged 6 commits into from
Aug 9, 2018

Conversation

flovilmart
Copy link
Contributor

@flovilmart flovilmart commented Aug 6, 2018

This PR does a few things:

  1. fix the issue with the headers, when running with an older parse-server
  2. updates the documentations for Cloud Code for parse-server 3.0. This is not ideal that the Cloud Code docs isn't in parse-server itself, but that's how it is, perhaps we could do something about it like a like or I dunno

@codecov
Copy link

codecov bot commented Aug 6, 2018

Codecov Report

Merging #624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #624   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          48       48           
  Lines        3850     3850           
  Branches      871      871           
=======================================
  Hits         3272     3272           
  Misses        578      578

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64aacec...96bbc72. Read the comment docs.

@flovilmart flovilmart force-pushed the release-2.0.1 branch 2 times, most recently from 13a2500 to 93439c1 Compare August 7, 2018 16:16
@flovilmart
Copy link
Contributor Author

@miconblog can you have a look there? as you went through the upgrade process, I'd like to release the fixes in the 2.0.1 as well as the upgrading guide.

@miconblog
Copy link
Contributor

yeb! i am already reading this guide. and migrating my project

@flovilmart
Copy link
Contributor Author

Let me know if there's anything missing or that you believe we should put :)

src/CloudCode.js Outdated
@@ -16,19 +18,19 @@
*
* If you want to use afterDelete for a predefined class in the Parse JavaScript SDK (e.g. {@link Parse.User}), you should pass the class itself and not the String for arg1.
* ```
* Parse.Cloud.afterDelete('MyCustomClass', (request) => {
* Parse.Cloud.afterDelete('MyCustomClass', async (request) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just curios about this CloudCode. Is it work in browser now? or is your long-team plan?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's in the server, but that's easier to have the whole cloud code API documentation with the rest of the JS SDK, we may move it at a later point if we generate a bigger API docs for parse-server.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, i see i just confused :)

src/CloudCode.js Outdated
@@ -62,19 +64,19 @@
*
* If you want to use beforeDelete for a predefined class in the Parse JavaScript SDK (e.g. {@link Parse.User}), you should pass the class itself and not the String for arg1.
* ```
* Parse.Cloud.beforeDelete('MyCustomClass', (request, response) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it remove response in beforeDelete?
i was used it before like this:

Parse.Cloud.beforeDelete('RedBookNote', async function (request, response) {
    response.success();
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In parse-server 3.0 (the the docs update is for parse-server 3.0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this leads to a lot of confusion, I'll bring in the CLoud Code docs in parse-server instead. And just add the link here. I'll revert cloud code docs for now :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goood :)

Copy link
Contributor

@miconblog miconblog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! thanks :)

@flovilmart flovilmart merged commit 2e69f39 into master Aug 9, 2018
@flovilmart flovilmart deleted the release-2.0.1 branch August 9, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants