-
-
Notifications
You must be signed in to change notification settings - Fork 597
Allow aggregate stages with same name #637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow aggregate stages with same name #637
Conversation
Instead of converting array to json for the payload just pass it though. The pipeline keyword needs to be added to the server.
}, { | ||
match: { 'tempPointer.value': 2 }, | ||
} | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check the alignment, it’s not nice :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make it beautiful soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it before we merge please...
}, { | ||
match: { 'tempPointer.value': 2 }, | ||
} | ||
]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it before we merge please...
@flovilmart I'm waiting for this to be merged. parse-community/parse-server#4959 |
Yeah but please fix the code first. |
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
- Coverage 85.53% 85.51% -0.02%
==========================================
Files 48 48
Lines 3899 3894 -5
Branches 882 881 -1
==========================================
- Hits 3335 3330 -5
Misses 564 564
Continue to review full report at Codecov.
|
Doing the eslint on this repo! |
That would be great |
Instead of converting array to json for the payload just pass it though.
Since I can't pass an array to the RESTController, The pipeline key needs to be added to the server for this to work.