Skip to content

Allow aggregate stages with same name #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2018

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 12, 2018

Instead of converting array to json for the payload just pass it though.

Since I can't pass an array to the RESTController, The pipeline key needs to be added to the server for this to work.

Instead of converting array to json for the payload just pass it though.

The pipeline keyword needs to be added to the server.
}, {
match: { 'tempPointer.value': 2 },
}
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the alignment, it’s not nice :/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make it beautiful soon

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it before we merge please...

}, {
match: { 'tempPointer.value': 2 },
}
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it before we merge please...

@dplewis
Copy link
Member Author

dplewis commented Aug 12, 2018

@flovilmart I'm waiting for this to be merged. parse-community/parse-server#4959

@flovilmart
Copy link
Contributor

Yeah but please fix the code first.

@dplewis dplewis closed this Aug 13, 2018
@dplewis dplewis reopened this Aug 13, 2018
@codecov
Copy link

codecov bot commented Aug 13, 2018

Codecov Report

Merging #637 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   85.53%   85.51%   -0.02%     
==========================================
  Files          48       48              
  Lines        3899     3894       -5     
  Branches      882      881       -1     
==========================================
- Hits         3335     3330       -5     
  Misses        564      564
Impacted Files Coverage Δ
src/ParseQuery.js 94.6% <100%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1353997...85ab394. Read the comment docs.

@flovilmart
Copy link
Contributor

Doing the eslint on this repo!

@dplewis
Copy link
Member Author

dplewis commented Aug 13, 2018

That would be great

@dplewis dplewis requested a review from flovilmart August 13, 2018 18:30
@dplewis dplewis merged commit ca9000e into parse-community:master Aug 13, 2018
@dplewis dplewis deleted the aggregate-multiple-stage branch August 13, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants