Skip to content

modernize cloud code #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2018
Merged

modernize cloud code #642

merged 4 commits into from
Aug 16, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

Parse.Cloud.job('CloudJob2', function() {
return new Promise((resolve) => {
setTimeout(function() {
resolve({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it's gonna work :)

@dplewis
Copy link
Member

dplewis commented Aug 16, 2018

I've been running into this test failing a lot.

1) Parse Query can do a query with a limit
  Message:
�[31m    Failed: 'qux' == 'baz'�[0m
  Stack:
    error properties: Object({ generatedMessage: true, code: 'ERR_ASSERTION', actual: 'qux', expected: 'baz', operator: '==' })
        at <Jasmine>
        at Parse.Object.saveAll.then.then (/Users/Squad/Github/Parse-SDK-JS/integration/test/ParseQueryTest.js:54:14)
        at <Jasmine>
        at process._tickDomainCallback (internal/process/next_tick.js:228:7)

@codecov
Copy link

codecov bot commented Aug 16, 2018

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          48       48           
  Lines        3876     3876           
  Branches      877      877           
=======================================
  Hits         3321     3321           
  Misses        555      555

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e8c44...8d30be8. Read the comment docs.

@flovilmart
Copy link
Contributor Author

@dplewis it makes sense as there is o guaraneed order when you save.

@dplewis dplewis merged commit 6855bd9 into master Aug 16, 2018
@dplewis dplewis deleted the cloud-code-modernization branch August 16, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants