Support object.exists() #898
Conversation
Codecov Report
@@ Coverage Diff @@
## master #898 +/- ##
==========================================
- Coverage 92.1% 92.05% -0.05%
==========================================
Files 54 54
Lines 5026 5036 +10
Branches 1127 1129 +2
==========================================
+ Hits 4629 4636 +7
- Misses 397 400 +3
Continue to review full report at Codecov.
|
src/ParseObject.js
Outdated
| await this.fetch(options); | ||
| return true; | ||
| } catch (e) { | ||
| return false; |
There was a problem hiding this comment.
I think we should check e.code === 101 and only return false in this case. Otherwise throw e. I am afraid that a network issue could be interpreted as an inexistent object.
There was a problem hiding this comment.
I was thinking here again. Maybe do a query by id would be better here instead of the fetch? I am not sure if the developer, when calling an exists() function, is expecting the object data to be updated.
Returns a promise boolean if the object exists on the server
See parse-community/parse-server#5950