Skip to content

Release 1.19.2 #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2021
Merged

Release 1.19.2 #1609

merged 2 commits into from
Mar 11, 2021

Conversation

drdaz
Copy link
Member

@drdaz drdaz commented Mar 10, 2021 •
edited by cbaker6
Loading

By popular demand, updates the Facebook SDK to 9.x.

Close #1608

@drdaz
Copy link
Member Author

drdaz commented Mar 10, 2021

@cbaker6 @TomWFox I don't have access to the Settings tab, so I can't access Secrets. Which is, I think, where the Cocoapods trunk token goes with this sweet new Actions getup.

Do we still need to worry about that? 🤔

@TomWFox
Copy link
Contributor

TomWFox commented Mar 10, 2021 •
edited
Loading

It's actually sharing an org level secret with a token that is shared with the Swift SDK & iOS Live query so with the high frequency of releases with any luck the token won't expire 🤞

Edit: soz for the terribly long wordy sentence 😅

@drdaz drdaz requested a review from a team March 10, 2021 20:44
TomWFox
TomWFox approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cbaker6
cbaker6 approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@cbaker6 cbaker6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Update: @drdaz I added the issue to the description so it automatically closes when you merge

@drdaz drdaz merged commit a8aab43 into master Mar 11, 2021
@drdaz drdaz deleted the release-1.19.2 branch March 11, 2021 16:04
@drdaz
Copy link
Member Author

drdaz commented Mar 11, 2021 •
edited by cbaker6
Loading

@cbaker6 the release worked you legend. There are downloads again 🎉🥳

@drdaz
Copy link
Member Author

drdaz commented Mar 11, 2021

Cocoapods deployed too!!!1!

@TomWFox
Copy link
Contributor

TomWFox commented Mar 11, 2021

Awesome, thanks @drdaz & @cbaker6 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@cbaker6 cbaker6 cbaker6 approved these changes

@TomWFox TomWFox TomWFox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trying to Install Parse/FacebookUtils with CocoaPods
3 participants
@drdaz @TomWFox @cbaker6