Skip to content

feat: Add support for compound AND queries with PFQuery.andQueryWithSubqueries #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 14, 2023
Merged

feat: Add support for compound AND queries with PFQuery.andQueryWithSubqueries #1733

merged 3 commits into from
Jul 14, 2023

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 11, 2023

New Pull Request Checklist

Issue Description

Similar functionality to PFQuery orWithSubqueries. Adds live query support for $and

Ref: parse-community/Parse-SDK-JS#367

Closes: n/a

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jul 11, 2023 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.72% and project coverage change: +6.08 🎉

Comparison is base (04f81e8) 78.17% compared to head (45851ca) 84.25%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1733      +/-   ##
==========================================
+ Coverage   78.17%   84.25%   +6.08%     
==========================================
  Files         307      248      -59     
  Lines       36879    30394    -6485     
==========================================
- Hits        28829    25609    -3220     
+ Misses       8050     4785    -3265
Impacted Files Coverage Δ
...lDataStore/OfflineQueryLogic/PFOfflineQueryLogic.m 62.68% <90.90%> (+1.04%) ⬆️
Parse/Parse/Source/PFQuery.m 94.28% <100.00%> (+0.04%) ⬆️
Parse/Tests/Unit/OfflineQueryLogicUnitTests.m 100.00% <100.00%> (ø)
Parse/Tests/Unit/QueryUnitTests.m 98.77% <100.00%> (+<0.01%) ⬆️

... and 83 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dplewis dplewis requested review from mtrezza and a team July 11, 2023 18:34
@mtrezza mtrezza removed their request for review July 12, 2023 08:17
@mtrezza mtrezza changed the title feat: Support Compound And Queries feat: Add support for compound and queries with PFQuery.andQueryWithSubqueries Jul 14, 2023
@mtrezza mtrezza changed the title feat: Add support for compound and queries with PFQuery.andQueryWithSubqueries feat: Add support for compound "and" queries with PFQuery.andQueryWithSubqueries Jul 14, 2023
@mtrezza mtrezza changed the title feat: Add support for compound "and" queries with PFQuery.andQueryWithSubqueries feat: Add support for compound AND queries with PFQuery.andQueryWithSubqueries Jul 14, 2023
mtrezza
mtrezza approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit bd09fe4 into parse-community:master Jul 14, 2023
parseplatformorg pushed a commit that referenced this pull request Jul 14, 2023
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
bca26ff 
# [2.6.0](2.5.0...2.6.0) (2023-07-14)

### Features

* Add support for compound AND queries with `PFQuery.andQueryWithSubqueries` ([#1733](#1733)) ([bd09fe4](bd09fe4))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 2.6.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jul 14, 2023
@dplewis dplewis deleted the and-query branch September 18, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dplewis @parseplatformorg @mtrezza