Allow clientKey to be nil, as it's not explicitly required for Open Parse Server. #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Any idea why CI failed? |
|
Yes, because Carthage comes preinstalled on few machines and we have #828 to handle that. |
Parse/Parse.h
Outdated
| @param clientKey The client key of your Parse application. | ||
| */ | ||
| + (void)setApplicationId:(NSString *)applicationId clientKey:(NSString *)clientKey; | ||
| + (void)setApplicationId:(NSString *)applicationId clientKey:(nullable NSString *)clientKey; |
There was a problem hiding this comment.
This should still be non null. If the server URL isn't changed (which only happens via the configuration initialization) client key is still required.
nlutsenko
force-pushed
the
nlutsenko.nullable.clientkey
branch
from
b5c0ada to
4a4404f
Compare
nlutsenko
force-pushed
the
nlutsenko.nullable.clientkey
branch
from
4a4404f to
5d47fc6
Compare
nlutsenko
added a commit
that referenced
this pull request
Feb 23, 2016
Allow clientKey to be nil, as it's not explicitly required for Open Parse Server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and closes #826.
cc @hramos