Skip to content

Fix not automatically registered subclasses of built-in subclasses of PFObject. #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Fix not automatically registered subclasses of built-in subclasses of PFObject. #976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Parse/Internal/Object/Subclassing/PFObjectSubclassingController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,10 @@ - (void)_registerSubclassesInBundle:(NSBundle *)bundle {
// Scary, I know!
for (Class kls = bundleClass; kls != nil; kls = class_getSuperclass(kls)) {
if (kls == pfObjectClass) {
// Do class_conformsToProtocol as late in the checking as possible, as its SUUUPER slow.
// Do -conformsToProtocol: as late in the checking as possible, as its SUUUPER slow.
// Behind the scenes this is a strcmp (lolwut?)
if (class_conformsToProtocol(bundleClass, @protocol(PFSubclassing)) &&
!class_conformsToProtocol(bundleClass, @protocol(PFSubclassingSkipAutomaticRegistration))) {
if ([bundleClass conformsToProtocol:@protocol(PFSubclassing)] &&
![bundleClass conformsToProtocol:@protocol(PFSubclassingSkipAutomaticRegistration)]) {
[self _rawRegisterSubclass:bundleClass];
}
break;
Expand Down