Skip to content

docs: add unsupported offline objects to migration guide #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Oct 21, 2022

New Pull Request Checklist

Issue Description

Offline storage is not supported by SDK, not documented in migration guide.

Related issue: #n/a

Approach

Add to migration guide.

TODOs before merging

n/a

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza requested a review from a team October 21, 2022 00:49
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Base: 90.36% // Head: 87.73% // Decreases project coverage by -2.62% ⚠️

Coverage data is based on head (9b71ed0) compared to base (8ec12ca).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   90.36%   87.73%   -2.63%     
==========================================
  Files         161      161              
  Lines       16267    16264       -3     
==========================================
- Hits        14699    14269     -430     
- Misses       1568     1995     +427     
Impacted Files Coverage Δ
Sources/ParseSwift/Objects/ParseObject.swift 73.96% <0.00%> (-16.84%) ⬇️
Sources/ParseSwift/Objects/ParseInstallation.swift 74.44% <0.00%> (-11.97%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 77.62% <0.00%> (-10.52%) ⬇️
...urces/ParseSwift/API/ParseURLSessionDelegate.swift 100.00% <0.00%> (ø)
Sources/ParseSwift/Coding/ParseEncoder.swift 78.14% <0.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza merged commit 6956072 into main Oct 21, 2022
@mtrezza mtrezza deleted the docs-migration-offline branch October 21, 2022 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants