Skip to content

Improve threading #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2021
Merged

Improve threading #51

merged 2 commits into from
Jan 12, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 12, 2021

  • Only use callbackQueue in the parse URLSession for progress updates (meaning progress can be specified on any queue the user wants.
  • In ParseURLSessionDelegate auto cleanup delegate task dictionary
  • Instead, each method in a ParseObject/Type is responsible for returning data to the correct thread
  • Fixed some places in ParseObject delete where a delete error might not have been given back to the user
  • Make saveAll run on it's own thread. When saveAll was fixed previously, depending on how it was called the async version could have ran on the main thread in which the OS would have started complaining eventually.

I'm hoping this fixes the random failure that only occurred in the 100 thread tests that has been hard to find...

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #51 (005406f) into main (806e026) will decrease coverage by 0.45%.
The diff coverage is 67.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   76.71%   76.25%   -0.46%     
==========================================
  Files          42       42              
  Lines        3757     3883     +126     
==========================================
+ Hits         2882     2961      +79     
- Misses        875      922      +47     
Impacted Files Coverage Δ
...urces/ParseSwift/API/ParseURLSessionDelegate.swift 21.05% <7.14%> (-3.09%) ⬇️
Sources/ParseSwift/Objects/ParseObject.swift 75.36% <60.17%> (-2.13%) ⬇️
Sources/ParseSwift/Objects/ParseUser.swift 75.73% <61.25%> (-2.77%) ⬇️
Sources/ParseSwift/Objects/ParseInstallation.swift 81.60% <64.56%> (-1.48%) ⬇️
Sources/ParseSwift/API/API+Commands.swift 82.31% <88.88%> (+1.56%) ⬆️
Sources/ParseSwift/Types/ParseFile.swift 88.23% <92.00%> (+0.94%) ⬆️
Sources/ParseSwift/Types/Query.swift 91.80% <96.15%> (+0.25%) ⬆️
Sources/ParseSwift/API/URLSession+extensions.swift 78.57% <100.00%> (+0.52%) ⬆️
Sources/ParseSwift/LiveQuery/LiveQuerySocket.swift 61.40% <100.00%> (ø)
Sources/ParseSwift/Types/ParseCloud.swift 97.43% <100.00%> (+0.13%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806e026...005406f. Read the comment docs.

@cbaker6 cbaker6 merged commit f5ebaba into main Jan 12, 2021
@cbaker6 cbaker6 deleted the threading branch January 12, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant