Skip to content

Complete overhaul #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2017
Merged

Complete overhaul #6

merged 2 commits into from
Sep 25, 2017

Conversation

flovilmart
Copy link
Contributor

@pranjalsatija what do you think?

  • Removes RESTCommand, moves to API.Command
  • All API calls are sync by default, to facilitate async and scheduling later
  • Adds more options for queries like sessionToken, installationId, with the same template, we could also inject safely custom headers etc...
  • API.Command is a value type now, no more subclassing for batch, just composition
  • ParseErrors are safe to use (imported from the original SDK)
  • All calls either succeed and return or throw, which makes it easier for tests etc...

@pranjalsatija
Copy link
Contributor

@flovilmart I think it looks great! Placing Command inside of API was a really good idea.

@pranjalsatija
Copy link
Contributor

Quick question. Will the SDK provide async interfaces for calls? Since everything is now synchronous by default, will it be up to the SDK's users to call things on the background thread or will we still build out async interfaces that wrap the synchronous methods?

@flovilmart
Copy link
Contributor Author

They are provided already :)

@flovilmart
Copy link
Contributor Author

@pranjalsatija
Copy link
Contributor

@flovilmart My bad, I didn't look hard enough. I'm in the middle of a bunch of stuff with exams and studying; sorry about that. Should I add Installation after you merge this?

@flovilmart
Copy link
Contributor Author

Focus on your exams! And yes you can probably get started on the Installation!

@pranjalsatija
Copy link
Contributor

pranjalsatija commented Sep 24, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants