Skip to content
This repository was archived by the owner on Feb 14, 2020. It is now read-only.

Support facebook-android-sdk >= 5 #51

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Support facebook-android-sdk >= 5 #51

merged 2 commits into from
Jul 3, 2019

Conversation

romanbsd
Copy link
Contributor

@romanbsd romanbsd commented Jul 1, 2019

The constructor parameters for AccessToken have changed in version 5.x of the Facebook SDK.

@rogerhu
Copy link
Contributor

rogerhu commented Jul 1, 2019

Thanks! Can you fix tests too?

/home/travis/build/parse-community/ParseFacebookUtils-Android/library/src/test/java/com/parse/facebook/FacebookControllerTest.java:95: error: no suitable constructor found for AccessToken(String,String,String,Set,,,Date,,)
AccessToken accessToken = new AccessToken(
^
constructor AccessToken.AccessToken(String,String,String,Collection,Collection,Collection,AccessTokenSource,Date,Date,Date) is not applicable
(actual and formal argument lists differ in length)
constructor AccessToken.AccessToken(Parcel) is not applicable
(actual and formal argument lists differ in length)
2 errors
:library:compileDebugUnitTestJavaWithJavac FAILED
:library:compileDebugUnitTestJavaWithJavac (Thread[Task worker for ':',5,main]) completed. Took 2.03 secs.

@romanbsd
Copy link
Contributor Author

romanbsd commented Jul 1, 2019

Will do

@romanbsd
Copy link
Contributor Author

romanbsd commented Jul 1, 2019

Tests pass

@mtrezza
Copy link
Member

mtrezza commented Jul 3, 2019

@Jawnnypoo Can you please check, merge, release?
I would also like to use FB SDK 5.x

@rogerhu rogerhu merged commit ddfa631 into parse-community:master Jul 3, 2019
@Jawnnypoo
Copy link
Member

Released as 1.14.0, enjoy!

@mtrezza
Copy link
Member

mtrezza commented Jul 3, 2019

@romanbsd Thanks for the PR!
@Jawnnypoo You are the best! Tested and works like a charm 🤙

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants