Revert the async disconnect change #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2017 18:02
This reverts commit 3b0041d The theory is that using OkHttp now, all networking is handled on the correct thread automatically. Closes parse-community#37
This also creates a new connectIfNeeded() method, which can be used to initiate a connection if not already connected or connecting. The original intent was to connectIfNeeded() during subscribe. While some may argue that's not necessary, and the client should instead be explicit about what is intended, this change preserves that original intention. As it stands, the only way to queue up pending subscriptions _without_ initiating a connection would be to call disconnect() first, even though the client hasn't been connected yet. That would set the user-initiated flag, which would therefore refuse to auto-connect during subscribe().
rogerhu
reviewed
Mar 30, 2017
| @@ -390,16 +390,6 @@ public void testEmptySessionTokenOnSubscribe() { | |||
| } | |||
|
|
|||
| @Test | |||
| public void testDisconnectOnBackgroundThread() throws Exception { | |||
| executor.pause(); | |||
There was a problem hiding this comment.
should we also get rid of the fancy executor too?
There was a problem hiding this comment.
It may be useful in the future if we need to test anything that happens asynchronously (like websocket connect/disconnect events, or something like that).
It will likely need to go away if/when #36 is done, because it won't be using an Executor anymore.
I can remove it for now if you think it's better not to have it if we're not using it?
There was a problem hiding this comment.
Sounds like we should just nuke...can't wait for #36 as well
Also introduces the ImmediateExecutor (same as what we used to have, before switching to PausableExecutor). Similar to, but simpler than, `bolts.BoltsExecutors#immediate()`.
rogerhu
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OkHttp WebSocket does all its work on the proper thread, so the async disconnect change is no longer needed.
Since the
disconnectAsync()change brings up a slew of other issues, it's best to just revert that change (3b0041d).Closes #37