Skip to content

Add dot notation key in query examples #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2019
Merged

Add dot notation key in query examples #488

merged 3 commits into from
Apr 25, 2019

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Nov 30, 2017 •
edited
Loading

@acinader acinader requested a review from montymxb November 30, 2017 20:38
@acinader acinader mentioned this pull request Nov 30, 2017
Merged
montymxb
montymxb previously requested changes Dec 2, 2017
View reviewed changes
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions look good. We probably want an example for the ios sdk while we're at it though.

@acinader acinader force-pushed the add-dot-notation-key-in-query-examples branch from 00f8748 to 3caf6c4 Compare October 16, 2018 22:15
@acinader acinader force-pushed the add-dot-notation-key-in-query-examples branch from 3caf6c4 to a8b46aa Compare October 16, 2018 22:18
@acinader acinader dismissed montymxb’s stale review October 16, 2018 22:20

I really don't use the IOS SDK

@acinader
Copy link
Contributor Author

@montymxb can you take another look at this

@TomWFox
Copy link
Contributor

TomWFox commented Apr 25, 2019

I've fixed a couple of formatting issues. It makes sense to get this merged in even without the iOS example and then we can open an issue.

@TomWFox
Copy link
Contributor

TomWFox commented Apr 25, 2019

@acinader are you happy for me to merge this in?

@acinader
Copy link
Contributor Author

yeah, getting my doc improvement from november of 17 merged in would make me happy. thanks for asking ;)

@TomWFox
Copy link
Contributor

TomWFox commented Apr 25, 2019

We're really prompt here ;)

@TomWFox TomWFox merged commit 784ed8f into gh-pages Apr 25, 2019
@TomWFox TomWFox deleted the add-dot-notation-key-in-query-examples branch April 25, 2019 22:11
@TomWFox
Copy link
Contributor

TomWFox commented Apr 25, 2019

Also I noticed that only the PHP docs have section headings for the different types of query constraints which is much easier to navigate than the other docs - I think I'll open an issue/pr for this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montymxb montymxb montymxb left review comments

Assignees
No one assigned
Labels
docs:sdk-android docs:sdk-js docs:sdk-php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acinader @TomWFox @montymxb