Skip to content

Remove outdated push notification content #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Conversation

TomWFox
Copy link
Contributor

@TomWFox TomWFox commented Mar 17, 2019

The option of client push has been removed from parse server, thus I have removed all sections that involve sending push notifications from the iOS SDK.

I have also tried to make it as clear as possible that client push is not allowed anymore and updated references with that in mind.

Addresses problems brought up by #405.

@TomWFox
Copy link
Contributor Author

TomWFox commented Mar 18, 2019

@acinader I know you don’t use the iOS SDK but could you cast an eye over this just to check that the changes seem in line with the removal of the ability of client push from parse server.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acinader acinader merged commit 89f7056 into gh-pages Mar 19, 2019
@acinader acinader deleted the push-updates branch March 19, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants