Skip to content

Correct inappropriate error message when no target audience is selected. #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Correct inappropriate error message when no target audience is selected. #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c194161
Correct inappropriate error message when no target audience is selected
starbassma Apr 6, 2019
e0cc7e0
Update CHANGELOG.md
TomWFox Apr 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
## Parse Dashboard Changelog
* _Contributing to this repo? Add info about your change here to be included in next release_

### master
[Full Changelog](https://github.com/parse-community/parse-dashboard/compare/1.3.0...master)

* _Contributing to this repo? Add info about your change here to be included in next release_
* Fix: Correct inappropriate error message when no target audience is selected (#1052), thanks to [Bouimadaghene](https://github.com/starbassma)

### 1.3.0
[Full Changelog](https://github.com/parse-community/parse-dashboard/compare/1.2.0...1.3.0)

Expand Down
2 changes: 1 addition & 1 deletion src/dashboard/Push/PushNew.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ class PushNew extends DashboardView {
let invalidInputMessages = [];

if (!this.state.audienceId) {
emptyInputMessages.push('you need select an audience');
emptyInputMessages.push('target audience');
}

// when number audience size is 0
Expand Down