feat: Include "count" CLP option #1180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davimacedo
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
Looks good to me. @alencarlucas do you mind to also take a look and share your feedback?
|
There is something weird with the state update. If you apply some changes in CLP and open the PermissionsDialog again the shown state is still the previous, but I'm not sure if it's related to this PR as well. |
|
I've just checked here and it is not related to this PR. I am merging this one and we can tackle the problem on a separate issue. |
|
Open the issue to fix the dialog state: #1182 |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Aug 25, 2019
* commit 'f74c4f38755f900b4b05653ce2e1f9c5b8904081': (40 commits) 1.4.3 (parse-community#1192) Version bump for 1.4.2 (parse-community#1190) 1.4.2 Release 🚀 (parse-community#1189) Update parse to the latest version 🚀 (parse-community#1188) Update query-string to the latest version 🚀 (parse-community#1186) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1185) Update webpack to the latest version 🚀 (parse-community#1184) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1183) feat: Include count CLP option (parse-community#1180) Update webpack to the latest version 🚀 (parse-community#1179) Update package-json to the latest version 🚀 (parse-community#1178) Update puppeteer to the latest version 🚀 (parse-community#1177) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1176) Update eslint-plugin-react to the latest version 🚀 (parse-community#1175) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1174) Update eslint to the latest version 🚀 (parse-community#1168) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1171) Update prismjs to the latest version 🚀 (parse-community#1170) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1169) Update eslint-plugin-jest to the latest version 🚀 (parse-community#1166) ... # Conflicts: # package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to set/unset CLP to run
countqueries through theSecurityDialogcomponent.Fixes #1165