Skip to content

style: require new line at the end of file #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2021
Merged

style: require new line at the end of file #1874

merged 4 commits into from
Oct 20, 2021

Conversation

damianstasik
Copy link
Contributor

New Pull Request Checklist

Issue Description

This PR adds a new rule to the ESLint config so that each file is required to end with a new line.

I also ran ESLint on all files just to make sure all files now end with a new line.

Related issue: #1870

Approach

  • Include the eol-last in the config file
  • Run ESLint on all files

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik
Copy link
Contributor Author

Ready for review 👍

@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2021 •
edited
Loading

@visualfanatic You seem to be on an amazing PR streak today! Would you be interested in officially joining the Parse Dashboard team as a contributor? This will also make it easier for you to request reviews using the GitHub feature in the top right corner that is disabled for non-members.

@damianstasik
Copy link
Contributor Author

damianstasik commented Oct 20, 2021 •
edited
Loading

@mtrezza Thanks!

Would you be interested in officially joining the Parse Dashboard team as a contributor?

I would love to!

@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2021

Great, I have opened a poll to formally propose your membership.

mtrezza
mtrezza approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit cbce861 into parse-community:alpha Oct 20, 2021
@parseplatformorg
Copy link
Contributor

🎉 This pull request has been released in version 3.3.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 20, 2021
@mtrezza mtrezza mentioned this pull request Oct 20, 2021
Closed
3 tasks
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2021
Merged
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 3.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damianstasik @mtrezza @parseplatformorg @visualfanatic