fix filter for negative and empty number input #749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanrolnik
suggested changes
Jul 14, 2017
| value={value} | ||
| onChange={(e) => { | ||
| let val = value; | ||
| if (!e.target.value.length) val = ''; |
There was a problem hiding this comment.
Please don't use if and else without brackets. This might lead to bugs. And already did in the history of programming many times :) Also, don't keep the val assignment in the same line.
|
@natanrolnik fixed the formatting and added the line to the Changelog file |
natanrolnik
approved these changes
Jul 14, 2017
|
LGTM! Thanks! |
|
This seems to have broken number filtering entirely for any 1-digit number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #557
Fixes two bugs with number input in filters: