Adds support for readOnly masterKey #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
force-pushed
the
read-only-masterKey
branch
from
b6bc8d0 to
3c13c58
Compare
acinader
reviewed
Oct 26, 2017
| @@ -77,7 +77,7 @@ module.exports = function(config, options) { | |||
| // Serve the configuration. | |||
| app.get('/parse-dashboard-config.json', function(req, res) { | |||
| let response = { | |||
| apps: config.apps, | |||
| apps: [...config.apps], // make a copy | |||
acinader
approved these changes
Oct 26, 2017
Parse-Dashboard/app.js
Outdated
|
|
||
| if (successfulAuth) { | ||
| if (appsUserHasAccess) { | ||
| // Restric access to apps defined in user dictionary | ||
| // If they didn't supply any app id, user will access all apps | ||
| response.apps = response.apps.filter(function (app) { | ||
| return appsUserHasAccess.find(appUserHasAccess => { | ||
| return app.appId == appUserHasAccess.appId | ||
| const isSame = app.appId == appUserHasAccess.appId; |
There was a problem hiding this comment.
prefer === :). i know its not yours....
Parse-Dashboard/Authentication.js
Outdated
| @@ -81,6 +81,7 @@ function initialize(app, options) { | |||
| function authenticate(userToTest, usernameOnly) { | |||
| var appsUserHasAccessTo = null; | |||
| var matchingUsername = null; | |||
| var isReadOnly = false; | |||
There was a problem hiding this comment.
switch all these to let? your call :)....
acinader
approved these changes
Oct 26, 2017
Parse-Dashboard/Authentication.js
Outdated
| @@ -96,12 +97,14 @@ function authenticate(userToTest, usernameOnly) { | |||
| matchingUsername = user.user; | |||
| // User restricted apps | |||
| appsUserHasAccessTo = user.apps || null; | |||
| isReadOnly = user.readOnly; | |||
| } | |||
|
|
|||
| return isAuthenticated; | |||
| }) ? true : false; | |||
There was a problem hiding this comment.
ewww, remove the ? true: false? as completely redundant?
acinader
reviewed
Oct 26, 2017
Parse-Dashboard/Authentication.js
Outdated
| } | ||
|
|
||
| return isAuthenticated; | ||
| }) ? true : false; | ||
| }) ? true : false ; |
There was a problem hiding this comment.
no because of the && && it was returning an object instead of true / false, and was breaking some tests.
acinader
reviewed
Oct 26, 2017
README.md
Outdated
|
|
||
| ### Making an app read-only for all users | ||
|
|
||
| Start your parse server with |
There was a problem hiding this comment.
parse-server for consistency?
There was a problem hiding this comment.
also could put readOnlyMasterKey masterKey insteaxc of masterKey....i.e. mark as code.
flovilmart
added a commit
that referenced
this pull request
Oct 27, 2017
* Adds support for readOnly masterKey * nits * Adds tests for readOnly * Updates documentation * nit * nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.