ParseFile use HttpClient for download #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 35 35
Lines 3166 3164 -2
==========================================
- Hits 3124 3122 -2
Misses 42 42
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts downloading for ParseFile to perform with the current HttpClient, rather than
curldirectly.Additionally this includes a fix to ParseStreamHttpClient where error messages & codes would not clear between individual requests. This properly cleans up prior errors on subsequent requests.
A couple typo fixes and test adjustments. Removed
follow_locationfrom thessloptions for the stream client, as the parameter is instead forhttpand the default is 1 anyways.Quick mention,
CURLOPT_BINARYTRANSFERwas not necessary to transfer files as it has no effect from php 5.1.3 onwards. Raw output is always returned withCURLOPT_RETURNTRANSFERon it's own.