Skip to content

Commit 758d2ac

Browse files
committed
Only removes GCS for now
1 parent 090521f commit 758d2ac

File tree

4 files changed

+15
-14
lines changed

4 files changed

+15
-14
lines changed

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@
3333
"mongodb": "~2.1.0",
3434
"multer": "^1.1.0",
3535
"parse": "^1.8.0",
36+
"parse-server-fs-adapter": "^1.0.0",
3637
"parse-server-push-adapter": "^1.0.0",
38+
"parse-server-s3-adapter": "^1.0.1",
39+
"parse-server-simple-mailgun-adapter": "^1.0.0",
3740
"redis": "^2.5.0-1",
3841
"request": "^2.65.0",
3942
"tv4": "^1.2.7",
@@ -58,10 +61,7 @@
5861
"jasmine": "^2.3.2",
5962
"mongodb-runner": "3.1.15",
6063
"nodemon": "^1.8.1",
61-
"parse-server-fs-adapter": "^1.0.0",
62-
"parse-server-gcs-adapter": "^1.0.0",
63-
"parse-server-s3-adapter": "^1.0.0",
64-
"parse-server-simple-mailgun-adapter": "^1.0.0"
64+
"parse-server-gcs-adapter": "^1.0.0"
6565
},
6666
"scripts": {
6767
"dev": "npm run build && node bin/dev",

spec/index.spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,9 @@ describe('server', () => {
242242
});
243243

244244
it('core adapters are not exposed anymore', done => {
245-
expect(ParseServer.S3Adapter).toThrow('S3Adapter is not provided by parse-server anymore; please install parse-server-s3-adapter');
245+
expect(ParseServer.S3Adapter).toThrow();
246246
expect(ParseServer.GCSAdapter).toThrow('GCSAdapter is not provided by parse-server anymore; please install parse-server-gcs-adapter');
247-
expect(ParseServer.FileSystemAdapter).toThrow('FileSystemAdapter is not provided by parse-server anymore; please install parse-server-fs-adapter');
247+
expect(ParseServer.FileSystemAdapter).toThrow();
248248
done();
249249
});
250250

src/deprecated.js

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
export function useExternal(name, moduleName) {
2+
return function() {
3+
throw `${name} is not provided by parse-server anymore; please install ${moduleName}`;
4+
}
5+
}

src/index.js

+4-8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
import winston from 'winston';
22
import ParseServer from './ParseServer';
3+
import S3Adapter from 'parse-server-s3-adapter'
4+
import FileSystemAdapter from 'parse-server-fs-adapter'
5+
import { useExternal } from './deprecated'
36

47
if (process.env.VERBOSE || process.env.VERBOSE_PARSE_SERVER) {
58
winston.level = 'silly';
@@ -17,14 +20,7 @@ let _ParseServer = function(options) {
1720
// Mount the create liveQueryServer
1821
_ParseServer.createLiveQueryServer = ParseServer.createLiveQueryServer;
1922

20-
function useExternal(name, moduleName) {
21-
return function() {
22-
throw `${name} is not provided by parse-server anymore; please install ${moduleName}`;
23-
}
24-
}
25-
let S3Adapter = useExternal('S3Adapter', 'parse-server-s3-adapter');
26-
let GCSAdapter = useExternal('GCSAdapter', 'parse-server-gcs-adapter')
27-
let FileSystemAdapter = useExternal('FileSystemAdapter', 'parse-server-fs-adapter')
23+
let GCSAdapter = useExternal('GCSAdapter', 'parse-server-gcs-adapter');
2824

2925
export default ParseServer;
3026
export { S3Adapter, GCSAdapter, FileSystemAdapter, _ParseServer as ParseServer };

0 commit comments

Comments
 (0)