Skip to content

Conversation

jashsayani
Copy link

See issue: #110

@jashsayani jashsayani mentioned this pull request Feb 1, 2016
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really we should have a default working sample app.js file somewhere and use that. The image built by this Dockerfile should have a runnable parse-server container with minimal efforts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah... So, the parse-server-example is that, basically... and there's a Dockerfile there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile runs index.js which is the main file. I could add a test.js that creates an instance of ParseServer.

Also, parse-server-example does not have a Dockerfile.

@gfosco
Copy link
Contributor

gfosco commented Feb 1, 2016

Since this is just the router package, and not a full server, I think the Dockerfile should reside in parse-server-example. I just merged a PR there which added it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants