Schema.js cleanup #1540
Merged
Schema.js cleanup #1540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
@drew-gross do you think it's time to move it to |
|
Yah I think once these changes are merged I will do that. |
| @@ -78,7 +78,7 @@ DatabaseController.prototype.loadSchema = function(acceptor = () => true) { | |||
| } | |||
| this.schemaPromise = this.schemaCollection().then(collection => { | |||
| delete this.schemaPromise; | |||
| return Schema.load(collection); | |||
| return Schema.load(collection, this.adapter); | |||
There was a problem hiding this comment.
we should probably store a SchemaController on this
There was a problem hiding this comment.
Yep, definitely will do something like that in a later PR.
|
LGTM, besides the baby comment, for later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of semi-random changes that are progress towards database adapters.