Skip to content

Remove acceptor parameter #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

drew-gross
Copy link
Contributor

This parameter doesn't seem to do anything, tests pass without it, and it makes shifting the schema to the database adapter impossible, so I'm removing it.

@gfosco can you explain why it was there in the first place? I generally try not to remove code I don't understand so I would like you to help me understand if possible.

@flovilmart
Copy link
Contributor

I believe it was to trigger a reload of the schema in case of race conditions

@drew-gross
Copy link
Contributor Author

What race condition though?

@codecov-io
Copy link

Current coverage is 92.79%

Merging #1553 into master will decrease coverage by -0.12% as of 2137e99

@@            master   #1553   diff @@
======================================
  Files           87      87       
  Stmts         5494    5484    -10
  Branches      1021    1019     -2
  Methods          0       0       
======================================
- Hit           5105    5089    -16
  Partial          9       9       
- Missed         380     386     +6

Review entire Coverage Diff as of 2137e99

Powered by Codecov. Updated on successful CI builds.

@drew-gross
Copy link
Contributor Author

The only way it's used is for checking if keys exist. If the keys don't exist, though, it doesn't create the keys. It just reloads and sends across the same old schema.

@flovilmart
Copy link
Contributor

I'll let @gfosco decide for that :)

@drew-gross
Copy link
Contributor Author

Got an over-the-shoulder review from @lacker, merging.

@drew-gross drew-gross merged commit bf47a0b into parse-community:master Apr 19, 2016
@drew-gross drew-gross deleted the remove-acceptor branch April 19, 2016 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants