S3Adapter: expose the object and use => for s3.upload callback #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfosco
added a commit
that referenced
this pull request
Feb 2, 2016
S3Adapter: expose the object and use => for s3.upload callback
bernhardharrer
pushed a commit
to bernhardharrer/parse-server
that referenced
this pull request
Feb 22, 2017
fixes mongolab config var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3Adapter was confusion to use because it wasn't exposed at the package level and this looks like something that a lot of people would use. Expose S3Adapter directly, which means usage to import will be:
Also changed callback of s3.upload call to use ES6's => for consistency.