#506 fix: Deleting a file does not delete from fs.files #1758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@maninga can you add a test in order to make sure that it's working correctly? |
* upstream/master: (63 commits) Fixes parse-community#1649 (parse-community#1650) Update issue template (parse-community#1899) Break schemaController dependency. (parse-community#1901) Remove unnecessary null check Update schema mismatch error to include type string (parse-community#1898) Move more mongo specific stuff into mongo adapter Kill mongoOptions Consistent parameter order move transformWhere into mongo adapter Remove options from count Can't sort a count Remove limit from count Destructure mongo options remove adaptive collection call create + use adapter count instead of collection count transformWhere in MongoAdapter remove schemaController paramater Remove schemaController parameter Remove getRelationFields Remove all dependencies on schemaController ...
|
@maninga updated the pull request. |
Current coverage is 91.84%@@ master #1758 diff @@
==========================================
Files 91 91
Lines 6385 6385
Methods 1111 1111
Messages 0 0
Branches 1337 1337
==========================================
Hits 5864 5864
Misses 521 521
Partials 0 0
|
…files and fs.chunks
|
ok, I just push that so the pull request is updated. |
|
@maninga updated the pull request. |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 15, 2017
parse-community#1758) * parse-community#506 fix: Deleting a file does not delete from fs.files * test added to check that GridStoreAdapter deleteFile removes from fs.files and fs.chunks
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 16, 2017
parse-community#1758) * parse-community#506 fix: Deleting a file does not delete from fs.files * test added to check that GridStoreAdapter deleteFile removes from fs.files and fs.chunks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As illustrated in https://mongodb.github.io/node-mongodb-native/api-generated/gridstore.html#unlink
the Gridstore should be instanciated on readOnly mode, then unlink removes from fs.chunks and fs.files