-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Implement Janrain Capture and Janrain Engage auth provider #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Modeled after the existing providers in /src/authDataManager/ and also after https://github.com/janrain/Janrain-Sample-Code/blob/master/widget-examples/server.js * See also: http://developers.janrain.com/overview/social-login/identity-providers/user-profile-data/#normalized-user-profile-data
Whoops, I added a breaking unit test. Sorry for the amateur hour. Will get that fixed. |
* Modeled after the existing providers in /src/authDataManager/ * See also: https://docs.janrain.com/api/registration/entity/#entity
Current coverage is 92.40% (diff: 82.19%)@@ master #2436 diff @@
==========================================
Files 93 95 +2
Lines 10629 10702 +73
Methods 1310 1327 +17
Messages 0 0
Branches 1728 1730 +2
==========================================
+ Hits 9829 9889 +60
- Misses 800 813 +13
Partials 0 0
|
@AndrewLane updated the pull request. |
@AndrewLane updated the pull request. |
1 similar comment
@AndrewLane updated the pull request. |
* Modeled after the existing providers in /src/authDataManager/ and also after https://github.com/janrain/Janrain-Sample-Code/blob/master/widget-examples/server.js * See also: http://developers.janrain.com/overview/social-login/identity-providers/user-profile-data/#normalized-user-profile-data
* Modeled after the existing providers in /src/authDataManager/ * See also: https://docs.janrain.com/api/registration/entity/#entity
module.exports = { | ||
validateAppId: validateAppId, | ||
validateAuthData: validateAuthData | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add line break
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify, the standard line break at the end of the file needs to be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, just added AndrewLane@b0fe257
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should i squash commits?
# Conflicts: # src/authDataManager/janraincapture.js # src/authDataManager/janrainengage.js
@AndrewLane updated the pull request. |
@AndrewLane updated the pull request. |
They are gonna Be squashed when merging |
👍 |
Fixes #2398
An addition to parse server to allow for authentication using Janrain. Janrain provides an Engage product as well as a Capture product, so there will be separate auth providers for each. It would be similar to Twitter, Facebook, etc. which are already implemented.
1) Janrain Engage Configuration:
The Janrain Engage API Key can be provided to Parse Server via configuration like:
2) Janrain Engage Auth Request
The POST to
/users
looks like:3) Janrain Capture Configuration:
The Janrain Capture host can be provided to Parse Server via configuration like:
4) Janrain Capture Auth Request
The POST to
/users
looks like: