Fix test:win, introduce coverage:win, fix test on Windows bash #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Fix test on windows bash
ghost
added
the
Current coverage is 91.87% (diff: 100%)@@ master #2453 diff @@
==========================================
Files 95 95
Lines 10699 10699
Methods 1309 1309
Messages 0 0
Branches 1740 1740
==========================================
Hits 9830 9830
Misses 869 869
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@flovilmart this reverts a change that you previously reverted which runs jasmine from the js file instead of the .bin/jasmine. If you look in .bin/jasmine it looks to be just be calling jasmine from the full path anyway.
I don't know why Windows bash has an issue with the jasmine sh script but this fixes it. Please let me know if this breaks code coverage for CI.
For developers without access to Windows 10 bash, then test:win should now work although mongodb-runner needs to be pinned at 3.2.0 for that to work due to a bug introduced in 3.2.1. I didn't roll it back here as figured there must be a reason it was increased.
I split out win:test coverage to coverage:win as to speed up testing when not interested in coverage.