Advancements with postgres #2510
Conversation
ghost
added
the
Current coverage is 91.92% (diff: 85.18%)@@ master #2510 diff @@
==========================================
Files 96 96
Lines 10867 10887 +20
Methods 1342 1345 +3
Messages 0 0
Branches 1756 1757 +1
==========================================
+ Hits 9984 10008 +24
+ Misses 883 879 -4
Partials 0 0
|
flovilmart
force-pushed
the
pg-advance
branch
2 times, most recently
from
de912ed to
8e988ef
Compare
| @@ -7,7 +7,7 @@ var FilesController = require('../src/Controllers/FilesController').default; | |||
|
|
|||
|
|
|||
| // Small additional tests to improve overall coverage | |||
| describe("GridStoreAdapter",() =>{ | |||
| describe_only_db('mongo')("GridStoreAdapter",() =>{ | |||
There was a problem hiding this comment.
only mongo as we don't start the DB when in PG mode
- Problem is with nested updates (param.prop = value)
- Adds support for nested json and . operator queries - Adds debug support for PG adapter - Adds loglevel support in helper
|
@drew-gross feel free to review when you have a minute. I feel this adapter pretty messy... Want to knock down as many tests as possible and then maybe refactor / extract. What do you think? |
| expect(error.code).toEqual(Parse.Error.DUPLICATE_VALUE); | ||
| }); | ||
| on_db('postgres', () => { | ||
| expect(error.code).toEqual('23505'); |
There was a problem hiding this comment.
I think this test should still be excluded in PG if it's not returning the right error code in PG. I thought on_db was going to be reserved for unsupported operations (like PG has no equivalent of mongo's $pullAll)
|
Looks amazing to me. I have a few comments about test strategy that I think should be fixed. The code has become pretty complex, but I think the basic structure is mostly sound, so no need to fix any of that right away. |
- Next thing is to implemenet geopoint and files correctly
flovilmart
changed the title
| @@ -13,6 +13,31 @@ const deepcopy = require('deepcopy'); | |||
|
|
|||
| const userSchema = SchemaController.convertSchemaToAdapterSchema({ className: '_User', fields: Object.assign({}, SchemaController.defaultColumns._Default, SchemaController.defaultColumns._User) }); | |||
|
|
|||
| describe_only_db('mongo')('miscellaneous', () => { | |||
There was a problem hiding this comment.
moved there as it tries to create a DB with mongo etc...
Initial status:
Aug. 15