Run Schema validations after beforeSave #2672 #2677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.11% (diff: 100%)@@ master #2677 diff @@
==========================================
Files 101 101
Lines 12304 12301 -3
Methods 1529 1529
Messages 0 0
Branches 2022 2022
==========================================
- Hits 11334 11331 -3
Misses 970 970
Partials 0 0
|
|
All is good with mongo, but PG is causing issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal will run the schemaValidation after the beforeSave so rejected beforeSave would have no side effects on the schema (adding a key for example) as described in #2672
Fixes #2672