Remoce deviceToken checking for android on saving installation #305
Conversation
|
Why do we want to allow |
|
@drew-gross, it is used to store Android GCM registration id. What do you mean Parse.com doesn't allow that? |
|
If you go to dasboard.parse.com/apps/_/browser/_Installation and try to create an installation with device type android and with a deviceToken you will get an error message. For installations created by the parse SDK, those are stored in installationId, I think. For imported installations, I'm pretty sure they are stored in GCMSenderID. You may want to double check that though. |
|
I know we can not create an android installation with deviceToken in dashboard although I am not quite sure about the reason. But for android SDK, I am pretty sure we do not use GCMSenderID to store the registration token. Right now all the GCM registration token is stored as deviceToken. I remember InstallationId is used for PPNS, we do not use that for GCM push. |
wangmengyan95
force-pushed
the
wangmengyan.remove_android_deviceToken_checking
branch
from
c06f046 to
66dfaf8
Compare
|
@wangmengyan95 updated the pull request. |
wangmengyan95
deleted the
wangmengyan.remove_android_deviceToken_checking
branch
|
This is still an issue. Not sure why it was closed? Doesn't seem fixed in any other pull requests. @drew-gross This is wrong. If you set the deviceToken, deviceType (android), and pushType (gcm) fields then is saves correctly. GCMSenderID is used for the server key used to send the notification (if you're not using Parse's own server key). |
|
This was fixed and merged in #405 |
No description provided.