Skip to content

add request headers to trigger functions #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions spec/CloudCode.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1200,6 +1200,61 @@ describe('Cloud Code', () => {
});
});

describe('beforeSave hooks', () => {
it('should have request headers', (done) => {
Parse.Cloud.beforeSave('MyObject', (req, res) => {
expect(req.headers).toBeDefined();
res.success();
});

const MyObject = Parse.Object.extend('MyObject');
const myObject = new MyObject();
myObject.save().then(() => done());
});
});

describe('afterSave hooks', () => {
it('should have request headers', (done) => {
Parse.Cloud.afterSave('MyObject', (req) => {
expect(req.headers).toBeDefined();
});

const MyObject = Parse.Object.extend('MyObject');
const myObject = new MyObject();
myObject.save()
.then(() => done());
});
});

describe('beforeDelete hooks', () => {
it('should have request headers', (done) => {
Parse.Cloud.beforeDelete('MyObject', (req, res) => {
expect(req.headers).toBeDefined();
res.success();
});

const MyObject = Parse.Object.extend('MyObject');
const myObject = new MyObject();
myObject.save()
.then(myObj => myObj.destroy())
.then(() => done());
});
});

describe('afterDelete hooks', () => {
it('should have request headers', (done) => {
Parse.Cloud.afterDelete('MyObject', (req) => {
expect(req.headers).toBeDefined();
});

const MyObject = Parse.Object.extend('MyObject');
const myObject = new MyObject();
myObject.save()
.then(myObj => myObj.destroy())
.then(() => done());
});
});

describe('beforeFind hooks', () => {
it('should add beforeFind trigger', (done) => {
Parse.Cloud.beforeFind('MyObject', (req) => {
Expand Down Expand Up @@ -1334,6 +1389,26 @@ describe('beforeFind hooks', () => {
});
});
});

it('should have request headers', (done) => {
Parse.Cloud.beforeFind('MyObject', (req) => {
expect(req.headers).toBeDefined();
});

const MyObject = Parse.Object.extend('MyObject');
const myObject = new MyObject();
myObject.save()
.then((myObj) => {
const query = new Parse.Query('MyObject');
query.equalTo('objectId', myObj.id);
return Promise.all([
query.get(myObj.id),
query.first(),
query.find(),
]);
})
.then(() => done());
});
});

describe('afterFind hooks', () => {
Expand Down Expand Up @@ -1531,4 +1606,25 @@ describe('afterFind hooks', () => {
done();
});
});

it('should have request headers', (done) => {
Parse.Cloud.afterFind('MyObject', (req, res) => {
expect(req.headers).toBeDefined();
res.success();
});

const MyObject = Parse.Object.extend('MyObject');
const myObject = new MyObject();
myObject.save()
.then((myObj) => {
const query = new Parse.Query('MyObject');
query.equalTo('objectId', myObj.id);
return Promise.all([
query.get(myObj.id),
query.first(),
query.find(),
]);
})
.then(() => done());
});
});
1 change: 1 addition & 0 deletions src/middlewares.js
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export function handleParseHeaders(req, res, next) {

info.app = AppCache.get(info.appId);
req.config = new Config(info.appId, mount);
req.config.headers = req.headers || {};
req.info = info;

var isMaster = (info.masterKey === req.config.masterKey);
Expand Down
6 changes: 4 additions & 2 deletions src/triggers.js
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ export function getRequestObject(triggerType, auth, parseObject, originalParseOb
triggerName: triggerType,
object: parseObject,
master: false,
log: config.loggerController
log: config.loggerController,
headers: config.headers,
};

if (originalParseObject) {
Expand Down Expand Up @@ -164,7 +165,8 @@ export function getRequestQueryObject(triggerType, auth, query, count, config, i
master: false,
count,
log: config.loggerController,
isGet
isGet,
headers: config.headers,
};

if (!auth) {
Expand Down