-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Update parse-server-s3-adapter to the latest version 🚀 #4016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4016 +/- ##
==========================================
- Coverage 90.73% 90.72% -0.02%
==========================================
Files 116 116
Lines 7937 7937
==========================================
- Hits 7202 7201 -1
- Misses 735 736 +1
Continue to review full report at Codecov.
|
@acinader any thing we should mention in the changelog now? |
@flovilmart upgrading to 1.2.0 will allow |
Has my best attempt at explaining the change and what to do about any deprecation notice someone may get. So something like: "parse-server-s3-adapter upgrade to 1.2.0 conforms passing credentials to AWS best practices. This change only emits a deprecation notice in the logs at this point in preperation for a future change that will no longer accept passed credentials. See: https://github.com/parse-server-modules/parse-server-s3-adapter/blob/master/README.md#deprecation-notice----aws-credentials for more details." |
@flovilmart is there somewhere i should put my changelog info so we can get this merged? |
Probably directly in this repo’s changelog, we’ll pick it up for next release (under a Next Release section at the top) |
superseded by #4118 |
Version 1.2.0 of parse-server-s3-adapter just got published.
The version 1.2.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of parse-server-s3-adapter.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 3 commits.
d8f9f17
1.2.0
f1c12e6
S3 overrides as option (#50)
65ec931
Give steps to get compliant with deprecated AWS credential change. (#51)
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴