Skip to content

PG: Support for nested contains and containedIn #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Aug 23, 2017

Closes #4099

Adds dot notation to containedIn and contains

@flovilmart
Copy link
Contributor

Wow! That's sweet!

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #4109 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4109      +/-   ##
==========================================
+ Coverage   90.71%   90.73%   +0.02%     
==========================================
  Files         116      116              
  Lines        7916     7935      +19     
==========================================
+ Hits         7181     7200      +19     
  Misses        735      735
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.46% <100%> (-0.04%) ⬇️
src/RestWrite.js 93.16% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c059f...0b058d1. Read the comment docs.

@flovilmart
Copy link
Contributor

That's awesome!

@flovilmart flovilmart merged commit c654621 into parse-community:master Aug 23, 2017
@dplewis dplewis deleted the containedIn-doc-notation branch August 23, 2017 15:59
@dplewis
Copy link
Member Author

dplewis commented Aug 23, 2017

No problem, I don't know how well support dot notation is among the other query constraints. We can add functionality for those in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants