Allows dot-notation to match against a complex structure when using matchesKeyInQuery #4308
Conversation
…using matchesKeyInQuery
Codecov Report
@@ Coverage Diff @@
## master #4308 +/- ##
==========================================
- Coverage 92.5% 92.48% -0.03%
==========================================
Files 118 118
Lines 8246 8246
==========================================
- Hits 7628 7626 -2
- Misses 618 620 +2
Continue to review full report at Codecov.
|
|
@bohemima unfortunately without any proper testing we can't really start to go through the process to review, even if it is just the one line. To help you out you would put a test down here in ParseQuery.spec.js . A format for such a test could be something like: it('should match complex structure with dot notation', function(done) {
// test code in here
// call done() to succeed
// call done.fail() to fail
});You can find plenty of examples of how to write a test case up by looking at any of the existing tests. If you take the time to put together something, even if it's not quite right, we'll work with you on it. That's what open source is about 👍 . |
|
@bohemima thanks! I've assigned myself to this, I'll take a look at it later 👍 . |
| @@ -335,7 +335,7 @@ RestQuery.prototype.replaceNotInQuery = function() { | |||
| const transformSelect = (selectObject, key ,objects) => { | |||
| var values = []; | |||
| for (var result of objects) { | |||
| values.push(result[key]); | |||
| values.push(key.split('.').reduce((o,i)=>o[i], result)); | |||
There was a problem hiding this comment.
If we change this for transformSelect we should also change the similar code in transformDontSelect. Additionally another test should then be added to account for doesNotMatchKeyInQuery having this modified behavior as well.
There was a problem hiding this comment.
Ah, yes, totally missed that. I'll give it a go soon (tm)
There was a problem hiding this comment.
Overall a nice little addition here. The extra change would have to be made over here on line 393 (as mentioned in the code), but that's just another one liner like what you've done already.
@flovilmart Although the tests indicate this is ok (and it does seem to be working just fine with the change) is there anything you might think of that this could cause an issue with?
|
@bohemima ping? |
|
fixed by: #4399 |
As the title suggests, this will allow dot notation to be used for matchesKeyInQuery, our use case is that we have a pointer we want to match against, simply using
result[key]does not cut it.Unfortunately I have not enough experience or time at the moment to write proper tests for this, so anyone is welcome to help with this PR.