Skip to content

refactoring database code #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 24, 2017
Merged

refactoring database code #4448

merged 3 commits into from
Dec 24, 2017

Conversation

vitaly-t
Copy link
Contributor

Starting to refactor the database code for better use of promises + ES6 generators, to prepare for ES7 await/async.

Starting to refactor the database code for better use of promises + ES6 generators, to prepare for ES7 await/async.
@codecov
Copy link

codecov bot commented Dec 24, 2017

Codecov Report

Merging #4448 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4448      +/-   ##
==========================================
- Coverage   92.69%   92.65%   -0.04%     
==========================================
  Files         118      118              
  Lines        8353     8349       -4     
==========================================
- Hits         7743     7736       -7     
- Misses        610      613       +3
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.82% <100%> (-0.12%) ⬇️
src/Adapters/Auth/meetup.js 84.21% <0%> (-5.27%) ⬇️
src/RestWrite.js 93.28% <0%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33de770...8443804. Read the comment docs.

@vitaly-t
Copy link
Contributor Author

Looks good, just need a reviewer.

@flovilmart 😉

naming the transaction.
Copy link
Contributor

@flovilmart flovilmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good!

@vitaly-t vitaly-t merged commit 08ba738 into master Dec 24, 2017
@vitaly-t vitaly-t deleted the vitaly-t-patch-1 branch December 24, 2017 15:58
flovilmart pushed a commit that referenced this pull request Dec 29, 2017
* refactoring database code

Starting to refactor the database code for better use of promises + ES6 generators, to prepare for ES7 await/async.

* Update PostgresStorageAdapter.js

* Update PostgresStorageAdapter.js

naming the transaction.
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
* refactoring database code

Starting to refactor the database code for better use of promises + ES6 generators, to prepare for ES7 await/async.

* Update PostgresStorageAdapter.js

* Update PostgresStorageAdapter.js

naming the transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants