-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
#6101 Let users define objectId #6177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you please take a look at the failing tests? |
I will do! I will try to work on this this week. |
@rhuanbarreto you can start off by checking the failing test in CI. I tried pushing changes but got denied. |
I opened my repository to edits publicly. I also merged your changes into the branch in this PR. |
Allow custom objectId
Codecov Report
@@ Coverage Diff @@
## master #6177 +/- ##
==========================================
- Coverage 93.81% 90.99% -2.83%
==========================================
Files 167 169 +2
Lines 11299 11957 +658
==========================================
+ Hits 10600 10880 +280
- Misses 699 1077 +378
Continue to review full report at Codecov.
|
@rhuanbarreto Can you verify the failing test? I can't seem to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davimacedo I want to try something. It looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @BufferUnderflower @rhuanbarreto @JeromeDeLeon Thanks for working together to get this done!
* parse-community#6101 Let users define objectId * Add `allowCustomObjectId` to PS Option * Add checking in objectId creation * Add test * Update docs * Update definition * Change default to false * throw on empty, null, undefined * better tests * unused async * removed comment * retain comment * Linting fix according to contributing spec.
Hello , i've changed the allowCustomObjectId to true in server settings in back4app. I can create a new object with custom Id through REST API. But when I try to do it through cloud code i get this error
Help would be really appreciated. |
Hello, your concern is duplicate of #6733. |
Yes it seem's like my concern is a duplicate , do you think this will be resolved anytime soon ? |
not at the moment. You could use http request inside cloud code to support your use case. |
This PR is a start of an idea discussed on issue #6101. Was created as a recommendation by @dplewis
This commit was a try to enable the generation of IDs on client-side.
I'm don't have much knowledge on Parse, but if someone give me guidance, I can do all the work.