-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix session expiration test #7208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7208 +/- ##
==========================================
- Coverage 94.03% 94.01% -0.02%
==========================================
Files 172 172
Lines 12867 12867
==========================================
- Hits 12099 12097 -2
- Misses 768 770 +2
Continue to review full report at Codecov.
|
The date comparison in |
Thanks for the heads up. I haven't noticed the other one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@davimacedo Is that something you wanted to change before merging? |
@mtrezza It was added already. |
Oh right, didn't notice that one. |
* Fix session expiration test * Fix the other test with similar issue * Remove fit
🎉 This change has been released in version 5.0.0-beta.1 |
🎉 This change has been released in version 5.0.0 |
New Pull Request Checklist
Issue Description
The session is flaky because a session is created and then the expiration date (that parse server created) is compared to a time got from the beginning of the test + the expiration span. Even if it is very fast, it can happen the two dates having different total minutes.
Related issue: #7180
Approach
I changed the test to check if the difference between the two dates is less then or equal to the jasmine test timeout limit.
TODOs before merging