Skip to content

fix: invalid file request not properly handled #8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2022
Merged

fix: invalid file request not properly handled #8059

merged 3 commits into from
Jun 17, 2022

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jun 17, 2022 •
edited
Loading

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 17, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #8059 (0088245) into release-4.x.x (8580a52) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 0088245 differs from pull request most recent head 86b53c4. Consider uploading reports for the commit 86b53c4 to get more accurate results

@@                Coverage Diff                @@
##           release-4.x.x    #8059      +/-   ##
=================================================
+ Coverage          93.82%   93.85%   +0.03%     
=================================================
  Files                170      170              
  Lines              12502    12507       +5     
=================================================
+ Hits               11730    11739       +9     
+ Misses               772      768       -4
Impacted Files Coverage Δ
src/Routers/FilesRouter.js 87.60% <100.00%> (+0.53%) ⬆️
src/RestWrite.js 93.60% <0.00%> (-0.17%) ⬇️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 96.09% <0.00%> (+0.15%) ⬆️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 93.37% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad680bd...86b53c4. Read the comment docs.

@mtrezza mtrezza changed the title fix fix: invalid file request not properly handled; this fixes a security vulnerability in which an invalid file request can crash the server ([GHSA-xw6g-jjvf-wwf9](https://github.com/parse-community/parse-server/security/advisories/GHSA-xw6g-jjvf-wwf9)) Jun 17, 2022
@mtrezza mtrezza changed the title fix: invalid file request not properly handled; this fixes a security vulnerability in which an invalid file request can crash the server ([GHSA-xw6g-jjvf-wwf9](https://github.com/parse-community/parse-server/security/advisories/GHSA-xw6g-jjvf-wwf9)) fix: invalid file request not properly handled Jun 17, 2022
@mtrezza mtrezza merged commit 5f42322 into parse-community:release-4.x.x Jun 17, 2022
@mtrezza mtrezza deleted the fix-file-release-4.x.x branch June 17, 2022 23:32
parseplatformorg pushed a commit that referenced this pull request Jun 17, 2022
@semantic-release-bot
chore(release): 4.10.12 [skip ci]
6286d2e 
## [4.10.12](4.10.11...4.10.12) (2022-06-17)

### Bug Fixes

* invalid file request not properly handled; this fixes a security vulnerability in which an invalid file request can crash the server ([GHSA-xw6g-jjvf-wwf9](GHSA-xw6g-jjvf-wwf9)) ([#8059](#8059)) ([5f42322](5f42322))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.10.12

@parseplatformorg parseplatformorg added the state:released-4.x.x Released as LTS version label Jun 17, 2022
@parse-github-assistant
Copy link

The label state:released-4.x.x cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the state:released-4.x.x Released as LTS version label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrezza @parseplatformorg