Skip to content

docs: describe additional database options #8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2022
Merged

docs: describe additional database options #8173

merged 3 commits into from
Sep 18, 2022

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Sep 18, 2022

New Pull Request Checklist

Issue Description

It is not clear that DatabaseOptions are directly passed to the client.

Related issue: #8168
Closes: #8168

Approach

Adds text explaining docs are directly passed to the client.

TODOs before merging

  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 18, 2022 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@dblythy dblythy marked this pull request as ready for review September 18, 2022 05:15
@dblythy dblythy requested a review from a team September 18, 2022 05:15
@codecov
Copy link

codecov bot commented Sep 18, 2022 •
edited
Loading

Codecov Report

Base: 94.21% // Head: 94.21% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (a9c5477) compared to base (3b775a1).
Patch has no changes to coverable lines.

❗ Current head a9c5477 differs from pull request most recent head c701f05. Consider uploading reports for the commit c701f05 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #8173      +/-   ##
==========================================
- Coverage   94.21%   94.21%   -0.01%     
==========================================
  Files         182      182              
  Lines       13733    13733              
==========================================
- Hits        12939    12938       -1     
- Misses        794      795       +1
Impacted Files Coverage Δ
src/Options/index.js 100.00% <ø> (ø)
src/batch.js 92.98% <0.00%> (-1.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

mtrezza
mtrezza reviewed Sep 18, 2022
View reviewed changes
mtrezza
mtrezza approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza closed this Sep 18, 2022
@mtrezza mtrezza reopened this Sep 18, 2022
@mtrezza mtrezza merged commit a5ba5da into parse-community:alpha Sep 18, 2022
@dblythy dblythy deleted the docs branch September 19, 2022 02:38
@dblythy dblythy mentioned this pull request Sep 19, 2022
Merged
3 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.3.0-alpha.27

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Sep 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Oct 29, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 19, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.0

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-5.x.x Released as LTS version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: databaseOptions missing in Parse Server Options docs
3 participants
@dblythy @parseplatformorg @mtrezza